Bug 570824 – [a11y] TreeView is not keyboard (re)focusable after

        selecting a cell in a non-sortable column

        * gtk/gtktreeview.c (gtk_tree_view_header_focus): Don't grab
        focus to a header button if it is not focusable. Problem reported
        by Joanmarie Diggs

svn path=/trunk/; revision=22316

diff --git a/ChangeLog b/ChangeLog
index 3d011fa98de46f3899f318b08f2ae7384fd55575..2f4f1b0e1840958bf54499834170f12e378c1250 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2009-02-11  Matthias Clasen  <mclasen@redhat.com>
+
+       Bug 570824 – [a11y] TreeView is not keyboard (re)focusable after 
+       selecting a cell in a non-sortable column
+
+       * gtk/gtktreeview.c (gtk_tree_view_header_focus): Don't grab
+       focus to a header button if it is not focusable. Problem reported
+       by Joanmarie Diggs
+
 2009-02-11  Matthias Clasen  <mclasen@redhat.com>
 
        Bug 508545 – No way to identify terminal classes from documentation

diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index cd0caceaa924c0a8b423cd71d3091d2cd17d9dd2..5078cdb8dc6f38d5a3b4cf0bee6ea5d23461cb06 100644 (file)
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -7707,7 +7707,7 @@ gtk_tree_view_header_focus (GtkTreeView      *tree_view,
     case GTK_DIR_DOWN:
       if (focus_child == NULL)
        {
-         if (tree_view->priv->focus_column != NULL)
+         if (tree_view->priv->focus_column != NULL && GTK_WIDGET_CAN_FOCUS (tree_view->priv->focus_column->button))
            focus_child = tree_view->priv->focus_column->button;
          else
            focus_child = GTK_TREE_VIEW_COLUMN (first_column->data)->button;